PR 848 clean up. #857
Draft
PR 848 clean up. #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjsjann123
commented
Jul 24, 2024
| @@ -3743,8 +3743,8 @@ def backward_fn(saved_for_backward, cotangents): | |||
| proxified if isinstance(entry, Proxy) else entry | |||
| for proxified, entry in zip(flat_saves_proxified, flat_saves) | |||
| ] | |||
| saved_for_backward = tree_unflatten(flat_filtered, saves_spec) | |||
| env = reconstruct_forward_env_for_backward(trace, saved_for_backward) | |||
| unproxiefied_saved_for_backward = tree_unflatten(flat_filtered, saves_spec) | |||
There was a problem hiding this comment.
@IvanYashchuk embarrassingly I don't quite get how this would work with a tree_map... how would I be able to zip two pytree while still keep them as a pytree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on PR review comments:
test clean up.